-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#16730 timezone enrichment documentation #16779
base: main
Are you sure you want to change the base?
#16730 timezone enrichment documentation #16779
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just had one minor change. We shouldn't reference master anymore. I think I may have sent you that link, so that's my bad.
Oh, I've been working off main, but my browser bookmark for the top level repo still goes to master. I can update the links. |
Update based on review Co-authored-by: victor-chaparro <[email protected]>
Quality Gate passedIssues Measures |
Update docs to mentions changes for time zone conversion translation to use enrichment schema
If you are suggesting a fix for a currently exploitable issue, please disclose the issue to the prime-reportstream team directly outside of GitHub instead of filing a PR, so we may immediately patch the affected systems before a disclosure. See SECURITY.md/Reporting a Vulnerability for more information.
Test Steps:
Changes
Added note for
convertDateTimeToReceiverLocalTimezone
and example configAdded note for example schema
Added note and linkback to new
migrating-receivers.md
note.Checklist
Testing
./prime test
or./gradlew testSmoke
against local Docker ReportStream container?npm run lint:write
?Process
Linked Issues
To Be Done
Create GitHub issues to track the work remaining, if any
Specific Security-related subjects a reviewer should pay specific attention to
If you answered 'yes' to any of the questions above, conduct a detailed Review that addresses at least: